🤖 fix: auto-expand inline comment textarea to fit content#14
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Use CSS `field-sizing: content` for modern browsers (Chrome 123+, Safari 26.2+) - Add JS fallback auto-resize for browsers without field-sizing support - Track user manual resize to avoid fighting with drag handle - Reset resize state when comment is cleared (for new comments) - Enable `resize-vertical` with `overflow-y: auto` for resize handle - Increase default minHeight to 160px (~8 lines) for better editing UX - Cap maxHeight at 50vh to prevent unbounded growth Fixes #11
kylecarbs
force-pushed
the
fix-issue-11
branch
from
8b2ee81 to
c8ba008
Compare
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11 - The inline comment dialog textarea now auto-expands to fit content and allows manual resizing.
Changes
resize-verticalTechnical Details
The auto-resize is achieved via a
useEffectthat resets height toautothen sets it toscrollHeighton every value change. This ensures the textarea matches content size while respecting CSS constraints.New props added to
MarkdownEditor:maxHeight(default:50vh) - configurable max height before scroll appears